fix(core): Add missing virtual keyword to ParticleSystemManagerDummy overrides#2486
Closed
bobtista wants to merge 1 commit intoTheSuperHackers:mainfrom
Closed
fix(core): Add missing virtual keyword to ParticleSystemManagerDummy overrides#2486bobtista wants to merge 1 commit intoTheSuperHackers:mainfrom
bobtista wants to merge 1 commit intoTheSuperHackers:mainfrom
Conversation
|
| Filename | Overview |
|---|---|
| Core/GameEngine/Include/GameClient/ParticleSys.h | Adds virtual keyword to 6 override methods in ParticleSystemManagerDummy, matching the virtual ... override style used throughout the base class ParticleSystemManager. |
Class Diagram
%%{init: {'theme': 'neutral'}}%%
classDiagram
class SubsystemInterface {
+virtual init()
+virtual reset()
+virtual update()
}
class Snapshot {
#virtual crc(Xfer*)
#virtual xfer(Xfer*)
#virtual loadPostProcess()
}
class ParticleSystemManager {
+virtual getOnScreenParticleCount() int
+virtual doParticles(RenderInfoClass&)
+virtual queueParticleRender()
#virtual crc(Xfer*) override
#virtual xfer(Xfer*) override
#virtual loadPostProcess() override
}
class ParticleSystemManagerDummy {
+virtual getOnScreenParticleCount() int override
+virtual doParticles(RenderInfoClass&) override
+virtual queueParticleRender() override
#virtual crc(Xfer*) override
#virtual xfer(Xfer*) override
#virtual loadPostProcess() override
}
SubsystemInterface <|-- ParticleSystemManager
Snapshot <|-- ParticleSystemManager
ParticleSystemManager <|-- ParticleSystemManagerDummy
Reviews (1): Last reviewed commit: "fix: Add missing virtual keyword to Part..." | Re-trigger Greptile
|
Perhaps this can be added to one of the other 3 pending pulls instead of adding just another one for such a trivial edit? |
Author
|
Folded into #2394 as suggested by xezon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing
virtualkeyword to 6 override functions inParticleSystemManagerDummy. This class was added after the GameEngine override PRs (#2391/#2392) merged, so it was missed in the sweep.